ssh: Fix template regex test for defaultExtensions to allow additional text#16018
Merged
stevendpclark merged 2 commits intomainfrom Jun 17, 2022
Merged
ssh: Fix template regex test for defaultExtensions to allow additional text#16018stevendpclark merged 2 commits intomainfrom
stevendpclark merged 2 commits intomainfrom
Conversation
- The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added
This was referenced Jun 17, 2022
stevendpclark
added a commit
that referenced
this pull request
Jun 17, 2022
…l text (#16018) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl
stevendpclark
added a commit
that referenced
this pull request
Jun 17, 2022
…l text (#16018) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl
stevendpclark
added a commit
that referenced
this pull request
Jun 17, 2022
…l text (#16018) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl
stevendpclark
added a commit
that referenced
this pull request
Jun 17, 2022
…l text (#16018) (#16037) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
stevendpclark
added a commit
that referenced
this pull request
Jun 17, 2022
…l text (#16018) (#16036) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
cipherboy
added a commit
that referenced
this pull request
Jun 20, 2022
…l text (#16018) (#16038) * ssh: Fix template regex test for defaultExtensions - The regex to identify if our defaultExtensions contains a template was a little too greedy, requiring the entire field to be just the regex. Allow additional text within the value field to be added * Add cl Co-authored-by: Steven Clark <steven.clark@hashicorp.com> Co-authored-by: Alexander Scheel <alex.scheel@hashicorp.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a little too greedy, requiring the entire field to be just the regex. Allow
additional text within the value field to be added