allow to skip TLS check in acme http-01 challenge#22521
Merged
stevendpclark merged 5 commits intohashicorp:mainfrom Nov 15, 2023
Merged
allow to skip TLS check in acme http-01 challenge#22521stevendpclark merged 5 commits intohashicorp:mainfrom
stevendpclark merged 5 commits intohashicorp:mainfrom
Conversation
Contributor
|
Hi @rubroboletus - thanks for the PR! Sorry for the delay here. We've taken a look at this internally:
If you want to take a look at simply skipping TLS verify in the redirect case (removing configuration), we'll accept that PR. If Thanks! |
Contributor
Author
|
Hi @kitography, ok, I have removed all the configurable logic and just simply ignore TLS. |
stevendpclark
approved these changes
Nov 15, 2023
Contributor
stevendpclark
left a comment
There was a problem hiding this comment.
@rubroboletus Thanks for the PR, much appreciated and sorry about the delay getting this merged.
I've added a test case so we don't accidentally break this in the future.
This was referenced Nov 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solves #22074 allows to set "tls_skip" on pki acme, which will skip TLS check on acme http-01 challenges.