Backport of Do not attempt to shutdown ACME thread on non-active nodes into release/1.14.x#23294
Merged
stevendpclark merged 1 commit intorelease/1.14.xfrom Sep 26, 2023
Conversation
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-20315-acme-do-not-close-channel/presumably-light-foal
branch
from
46d9c55 to
72a9e36
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/stevendpclark/vault-20315-acme-do-not-close-channel/presumably-light-foal
branch
from
72a9e36 to
46d9c55
Compare
|
|
github-actions
bot
added
the
hashicorp-contributed-pr
stevendpclark
force-pushed
the
backport/stevendpclark/vault-20315-acme-do-not-close-channel/presumably-light-foal
branch
from
dd8cffd to
c14a718
Compare
sgmiller
approved these changes
Sep 26, 2023
|
Build Results: |
stevendpclark
deleted the
backport/stevendpclark/vault-20315-acme-do-not-close-channel/presumably-light-foal
branch
|
CI Results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23293 to be assessed for backporting due to the inclusion of the label backport/1.14.x.
🚨
The person who merged in the original PR is:
@stevendpclark
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.
The below text is copied from the body of the original PR.
Missed this from #23278, we need to optionally close out the plugin if we aren't the active node.
Overview of commits