Allow AWS secret engine to send empty policy document#23470
Merged
Monkeychip merged 2 commits intomainfrom Oct 3, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
hellobontempo
approved these changes
Oct 3, 2023
Contributor
hellobontempo
left a comment
hellobontempo
left a comment
There was a problem hiding this comment.
Nice job tackling!
This was referenced Oct 4, 2023
Monkeychip
added a commit
that referenced
this pull request
Oct 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a regression caused by a PR here that fixed a larger issue.
AWS is a unique case where we can't default the json form field to an empty object. A user needs to return nothing if no
policy_documentis added.With the fix:
Screen.Recording.2023-10-03.at.11.29.27.AM.mov