Replace KV v2 List route with wildcard instead of dynamic segment#23620
Merged
Monkeychip merged 7 commits intomainfrom Oct 13, 2023
Merged
Replace KV v2 List route with wildcard instead of dynamic segment#23620Monkeychip merged 7 commits intomainfrom
Monkeychip merged 7 commits intomainfrom
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
…b.com/hashicorp/vault into ui/VAULT-20812/bug-fix-kv-list-encode
Monkeychip
changed the title
|
Build Results: |
Monkeychip
added a commit
that referenced
this pull request
Oct 16, 2023
…3620) * initial work on the LIST route. * fix * changelog * add s * add in prepending forward slash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22539.
We were using a dynamic segment in the middle of a URL. This would be fine if that segment did not have the potential to contain a forward slash. In routing this forward slash was encoded by the router, but when you copy pasted that URL it was decoded and led to incorrect routes.
The fix was to replace this with a wildcard letting the router know to expect things such as forward slashes.
Screen share of the fix below
kv-fx.mov