UI: [VAULT-20186] decode uri for all attributes in the table#23695
Merged
kiannaquach merged 3 commits intomainfrom Oct 17, 2023
Merged
UI: [VAULT-20186] decode uri for all attributes in the table#23695kiannaquach merged 3 commits intomainfrom
kiannaquach merged 3 commits intomainfrom
Conversation
kiannaquach
changed the title
github-actions
bot
added
the
hashicorp-contributed-pr
zofskeez
reviewed
Oct 17, 2023
Contributor
zofskeez
left a comment
zofskeez
left a comment
There was a problem hiding this comment.
This looks good to me but maybe a test to cover the specific case would be good to ensure an encoded connection url is decoded as expected?
|
Build Results: |
Contributor
Author
|
@zofskeez Just added the test! 😬 |
zofskeez
reviewed
Oct 17, 2023
Comment on lines
+487
to
+498
| test('connection_url must be decoded', async function (assert) { | ||
| const backend = this.backend; | ||
| const connection = await newConnection( | ||
| backend, | ||
| 'mongodb-database-plugin', | ||
| '{{username}}/{{password}}@oracle-xe:1521/XEPDB1' | ||
| ); | ||
| await navToConnection(backend, connection); | ||
| assert | ||
| .dom('[data-test-row-value="Connection URL"]') | ||
| .hasText('{{username}}/{{password}}@oracle-xe:1521/XEPDB1'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Just to verify, if you remove the decode-uri helper from the template this test fails?
Contributor
There was a problem hiding this comment.
Perfect thanks for adding this test!
zofskeez
approved these changes
Oct 17, 2023
Comment on lines
+487
to
+498
| test('connection_url must be decoded', async function (assert) { | ||
| const backend = this.backend; | ||
| const connection = await newConnection( | ||
| backend, | ||
| 'mongodb-database-plugin', | ||
| '{{username}}/{{password}}@oracle-xe:1521/XEPDB1' | ||
| ); | ||
| await navToConnection(backend, connection); | ||
| assert | ||
| .dom('[data-test-row-value="Connection URL"]') | ||
| .hasText('{{username}}/{{password}}@oracle-xe:1521/XEPDB1'); | ||
| }); |
Contributor
There was a problem hiding this comment.
Perfect thanks for adding this test!
This was referenced Oct 17, 2023
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
connection_urlwas being displayed with encoded characters. I added adecode_urihelper to decode_uri's in templates.Bug:
After decoding:
