Skip to content

Pin curl docker image to a specific version instead of latest#23763

Merged
stevendpclark merged 1 commit intomainfrom
stevendpclark/pin-curl-docker-image
Oct 24, 2023
Merged

Pin curl docker image to a specific version instead of latest#23763
stevendpclark merged 1 commit intomainfrom
stevendpclark/pin-curl-docker-image

Conversation

@stevendpclark
Copy link
Copy Markdown
Contributor

  • Try to avoid these build failures as our proxy does seem to have issues around pulling images with the 'latest' tag at times.
acme_test.go:206:
	Error Trace:	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pkiext/pkiext_binary/acme_test.go:206
          	        /home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pkiext/pkiext_binary/acme_test.go:75
	Error:      	Received unexpected error:
				container create failed: Error response from daemon: No such image: docker.mirror.hashicorp.services/curlimages/curl:latest
	Test:       	Test_ACME/group/caddy_http_eab
	Messages:   	could not start cURL container

 - Try to avoid these build failures as our proxy does seem to have
   issues around pulling images with the 'latest' tag at times.

```
acme_test.go:206:
	Error Trace:	/home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pkiext/pkiext_binary/acme_test.go:206
          	        /home/runner/actions-runner/_work/vault-enterprise/vault-enterprise/builtin/logical/pkiext/pkiext_binary/acme_test.go:75
	Error:      	Received unexpected error:
				container create failed: Error response from daemon: No such image: docker.mirror.hashicorp.services/curlimages/curl:latest
	Test:       	Test_ACME/group/caddy_http_eab
	Messages:   	could not start cURL container
```
@stevendpclark stevendpclark self-assigned this Oct 20, 2023
@stevendpclark stevendpclark requested a review from a team as a code owner October 20, 2023 14:50
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 20, 2023
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@stevendpclark stevendpclark changed the title Pin curl docker image to a specific docker version instead of latest Pin curl docker image to a specific version instead of latest Oct 20, 2023
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

Copy link
Copy Markdown
Contributor

@victorr victorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants