core: fix bug where deadlock detection was always on for expiration and quotas#23902
Merged
jasonodonnell merged 7 commits intomainfrom Oct 30, 2023
Merged
core: fix bug where deadlock detection was always on for expiration and quotas#23902jasonodonnell merged 7 commits intomainfrom
jasonodonnell merged 7 commits intomainfrom
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
ncabatoff
approved these changes
Oct 30, 2023
Collaborator
ncabatoff
left a comment
ncabatoff
left a comment
There was a problem hiding this comment.
Missing changelog but otherwise seems good to go.
hghaf099
reviewed
Oct 30, 2023
hghaf099
reviewed
Oct 30, 2023
hghaf099
approved these changes
Oct 30, 2023
|
Build Results: |
This was referenced Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #18604 introduced a bug where deadlock detection was always on for both expiration and quota subsystems. This can result in negative server performance as deadlock detection adds overhead to locks.
Deadlock detection can now be toggled on expiration and quotas via
detect_deadlocks="statelock,expiration,quotas".