Skip to content

Fix race that can lead to panic during seal #23906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
banks merged 2 commits into from
Oct 30, 2023
Merged

Fix race that can lead to panic during seal #23906

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45b733f
Fix race that can lead to panic during seal
banks Oct 30, 2023
6d4d706
Add changelog
banks Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/23906.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
core: fix rare panic due to a race condition with metrics collection during seal
```
8 changes: 4 additions & 4 deletions vault/core_metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,14 +597,14 @@ func (c *Core) inFlightReqGaugeMetric() {

// configuredPoliciesGaugeCollector is used to collect gauge label values for the `vault.policy.configured.count` metric
func (c *Core) configuredPoliciesGaugeCollector(ctx context.Context) ([]metricsutil.GaugeLabelValues, error) {
if c.policyStore == nil {
return []metricsutil.GaugeLabelValues{}, nil
}

c.stateLock.RLock()
policyStore := c.policyStore
c.stateLock.RUnlock()

if policyStore == nil {
return []metricsutil.GaugeLabelValues{}, nil
}

ctx = namespace.RootContext(ctx)
namespaces := c.collectNamespaces()

Expand Down