OIDC/JWT Role Fetch Error Handling Updates#23908
Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
kiannaquach
reviewed
Oct 30, 2023
austingebauer
approved these changes
Nov 1, 2023
Contributor
austingebauer
left a comment
austingebauer
left a comment
There was a problem hiding this comment.
Nice improvement to help with troubleshooting. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with error handling in the
AuthJwtcomponent where errors when attempting to fetch the role were being thrown with no catch. This gave the user the impression that nothing was happening when they would try to login via OIDC/JWT. This PR updates the workflow to surface all role related fetch errors so the user can better troubleshoot setup issues.The attached video illustrates a 403 error that would have previously been unhandled and is now displayed as an alert. The network inspector is also visible to illustrate that when changing mount path or type that a request is made to fetch the role which is necessary to determine whether or not the mount is configured for JWT authentication. This is only provided as verification that regressions were not introduced in the workflow and is existing functionality.
Screen.Recording.2023-10-30.at.2.10.47.PM.mov
Example of unhandled error before updates