Command: token capabilities using accessor#24479
Merged
marcboudreau merged 3 commits intohashicorp:mainfrom Dec 13, 2023
mattias-fjellstrom:command/capabilities-accessor
Merged
Command: token capabilities using accessor#24479marcboudreau merged 3 commits intohashicorp:mainfrom mattias-fjellstrom:command/capabilities-accessor
marcboudreau merged 3 commits intohashicorp:mainfrom
mattias-fjellstrom:command/capabilities-accessor
Conversation
marcboudreau
suggested changes
Dec 12, 2023
Contributor
marcboudreau
left a comment
marcboudreau
left a comment
There was a problem hiding this comment.
Looks good. I was going to ask that the Usage for the capabilities command be updated to include the -accessor case, but the existing pattern didn't make much sense, so I've suggested a wholesale change of the entire description.
Co-authored-by: Marc Boudreau <marc.boudreau@hashicorp.com>
marcboudreau
approved these changes
Dec 13, 2023
Contributor
marcboudreau
left a comment
marcboudreau
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution, I'll get this merged once all of the Github status checks have passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24478