VAULT-22642: Include secret syncs in activity log responses#24710
Merged
miagilepner merged 6 commits intomainfrom Jan 15, 2024
Merged
VAULT-22642: Include secret syncs in activity log responses#24710miagilepner merged 6 commits intomainfrom
miagilepner merged 6 commits intomainfrom
Conversation
miagilepner
force-pushed
the
miagilepner/VAULT-22642-secret-sync-resp
branch
from
134d6c8 to
48be56c
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
mpalmi
approved these changes
Jan 9, 2024
Contributor
mpalmi
left a comment
mpalmi
left a comment
There was a problem hiding this comment.
This looks good to me. No major glaring issues that I could see, but I'll give it another pass tomorrow to be sure.
I did have a few questions around code organization, but none of the comments are super important.
mpalmi
approved these changes
Jan 12, 2024
Contributor
mpalmi
left a comment
mpalmi
left a comment
There was a problem hiding this comment.
Updates look good. Just added one last note about a godoc update for the new Add methods, but it's not a dealbreaker so still keeping this Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the documentation will be in a different PR.