Skip to content

Transit Active Tab#25614

Merged
zofskeez merged 3 commits intomainfrom
ui/VAULT-24354/transit-tab-bug
Feb 26, 2024
Merged

Transit Active Tab#25614
zofskeez merged 3 commits intomainfrom
ui/VAULT-24354/transit-tab-bug

Conversation

@zofskeez
Copy link
Contributor

@zofskeez zofskeez commented Feb 23, 2024

This PR fixes an issue where transitioning from the transit edit route to the show route would result in none of the tabs being active.

image

After fix

Screen.Recording.2024-02-23.at.12.24.48.PM.mov

@zofskeez zofskeez added ui bug Used to indicate a potential bug labels Feb 23, 2024
@zofskeez zofskeez added this to the 1.16.1 milestone Feb 23, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 23, 2024
@github-actions
Copy link

github-actions bot commented Feb 23, 2024

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link

github-actions bot commented Feb 23, 2024

Build Results:
All builds succeeded! ✅

@zofskeez zofskeez modified the milestones: 1.16.1, 1.16.0 Feb 23, 2024
@zofskeez zofskeez enabled auto-merge (squash) February 23, 2024 21:25
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. It annoyed me every time I saw it but was trying to keep my focus on the transit key actions.

@zofskeez zofskeez merged commit d4706b5 into main Feb 26, 2024
@zofskeez zofskeez deleted the ui/VAULT-24354/transit-tab-bug branch February 26, 2024 16:02
kiannaquach pushed a commit that referenced this pull request Feb 26, 2024
* fixes issue with no active tab in transit show route

* adds changelog

* updates test assertion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Used to indicate a potential bug hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants