Backport of VAULT-24013: Audit regression attempting to recover from panic into release/1.16.x#25622
Merged
peteski22 merged 1 commit intorelease/1.16.xfrom Feb 26, 2024
Conversation
hc-github-team-secure-vault-core
force-pushed
the
backport/peteski22/VAULT-24013/audit/panic/heartily-rested-satyr
branch
from
718fb65 to
1ec04e4
Compare
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
peteski22
approved these changes
Feb 26, 2024
peteski22
deleted the
backport/peteski22/VAULT-24013/audit/panic/heartily-rested-satyr
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #25605 to be assessed for backporting due to the inclusion of the label backport/1.16.x.
The below text is copied from the body of the original PR.
This PR fixes a regression in recovering Vault when audit related code panics. It appeared with the introduction of the go-eventlogger.
The changes involve continuing to handle the metrics updates in the audit broker, but making an entry formatter node responsible for handling panics that occur during formatting of the audit entry.
Addresses: #16462
Overview of commits