UI: Only add user lockout config for supported methods#25867
Merged
hellobontempo merged 4 commits intomainfrom Mar 11, 2024
Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
…unsupported-methods
|
Build Results: |
hashishaw
approved these changes
Mar 11, 2024
Contributor
hashishaw
left a comment
hashishaw
left a comment
There was a problem hiding this comment.
Very clean, thank you!
hellobontempo
deleted the
ui/VAULT-24800/hide-user-lockout-config-for-unsupported-methods
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I added these params in #25646 - I missed that they're only supported by
approle,ldap, anduserpass- this PR fixes that!enterprise tests ✅
