Add acme clients internal data structures and adjust tests#26020
Merged
raskchanky merged 4 commits intomainfrom Mar 19, 2024
Merged
Add acme clients internal data structures and adjust tests#26020raskchanky merged 4 commits intomainfrom
raskchanky merged 4 commits intomainfrom
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
Collaborator
Author
|
I'm thinking maybe no changelog for this PR, since it's just internal changes? |
miagilepner
reviewed
Mar 19, 2024
Collaborator
This does change |
Collaborator
Author
|
@miagilepner Thanks for catching my changelog oversight! Added in d9987d6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hashicorp.atlassian.net/browse/VAULT-24625
I applied the diff on the linked Jira and adjusted a few tests. Some of the tests mentioned in the Jira didn't look like they needed adjusting? Or maybe I misread them?