Bug: fixed cases where CodeMirror textarea inputs did not have associated labels#26263
Merged
Bug: fixed cases where CodeMirror textarea inputs did not have associated labels#26263
Conversation
|
Build Results: |
|
CI Results: |
andaley
approved these changes
Apr 4, 2024
Contributor
andaley
left a comment
There was a problem hiding this comment.
these code changes look great! thank you so much for proactively noticing this problem and adding a fix so quickly. once the build jobs all succeed this looks good to go on my end; go ahead and merge it and i'll make sure it gets included in the next release. 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If merged, this PR: