Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
andaley
approved these changes
May 2, 2024
Contributor
andaley
left a comment
andaley
left a comment
There was a problem hiding this comment.
thank you for fixing this so quickly!
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you were in a namespace and you activated the feature the secrets.overview model would not refresh. Because this model is generated from the route and not a backing ember data model, it's not super easy to just pass in the model to the transitionTo method. Instead, we need to trigger the model refresh manually via the router.refresh() method.
Before within namespace
old.mov
After within a namespace
after.mov
Enterprise tests pass (sync specific, still issues running replication test locally)
I checked if this was an issue on 1.16.x or maybe a result of a recent dependency upgrade but it appears to be a bug there as well.