UI: improve DR Operation Token flow with PGP #26993
Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
Monkeychip
reviewed
May 13, 2024
Monkeychip
approved these changes
May 13, 2024
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
One question, non-blocking. Great solution.
1 task
hashishaw
added a commit
that referenced
this pull request
May 28, 2024
hashishaw
added a commit
that referenced
this pull request
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the DR Operation Token flow when using a PGP key. It replaces the CopySnippet component with CodeBlock which supports line wrapping, and it is updated so that errors returned from the API after clicking "Generate Operation Token" will show on the PGP screen.
After:
Before:
This is only being backport to 1.16 because CodeSnippet was released in Helios 3.1.0 and Vault upgraded to v3 in 1.16