Open
Conversation
The test reads these if they exist. They likely don't exist in CI, but my files were read and changed the test's behavior by not returning the expected error response.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently opened #27404 and had a possible fix, but
make testhad failures. These changes are not at all related to each other, but they seemed trivial enough to combine and to skip issue creation. I'd be happy to split this apart and/or create a dedicated issue if I'm wrong.For the AWS change, my first instinct was to make those changes "higher up" (e.g. in the
Makefileor in the build scripts), but I chose to be conservative. I'm a long-time user of Vault, but I'm new to the build/test process.For the consul test, the bug report that led to this test (#23013) was more likely to occur with Enterprise, which is likely why that image was used. I do know the test passes using the OSS image, but I don't know if that reduces the usefulness of the test. I can get a license, but I saw (unofficial) comments in places that suggested that "regular devs" aren't expected to have a license when running the tests locally. I could not find any obvious mechanism for ignoring enterprise-specific tests, so, for this change, I chose to assume: