Backport of improve autopilot logging when it starts up into release/1.17.x#27466
Merged
raskchanky merged 1 commit intorelease/1.17.xfrom Jun 12, 2024
Merged
Conversation
9746c5f to
1eb6200
Compare
raskchanky
approved these changes
Jun 12, 2024
|
CI Results: |
|
Build Results: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #27464 to be assessed for backporting due to the inclusion of the label backport/1.17.x.
The below text is copied from the body of the original PR.
Description
While dealing with an autopilot escalation, I noticed that the logging when autopilot starts up is suboptimal, for a few reasons.
reconcile_interval 0sis printed to the logs, which is incorrect, and actually alarming. What's happening is it's printing out the value of the reconcile interval as it exists on the raft backend, which is 0 by default, but that's not actually the value autopilot is using. This is misleading.This makes the autopilot config struct print in a better way and also updates the logging to not actually print the values for reconcile interval or update interval unless they were actually changed from their defaults.
TODO only if you're a HashiCorp employee
getting backported to N-2, use the new style
backport/ent/x.x.x+entlabelsinstead of the old style
backport/x.x.xlabels.the normal
backport/x.x.xlabel (there should be only 1).of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
Overview of commits