Skip to content

VAULT-28255: Fix namespaced redirects#27660

Merged
miagilepner merged 4 commits intomainfrom
miagilepner/events-namespace-forwarding
Jul 3, 2024
Merged

VAULT-28255: Fix namespaced redirects#27660
miagilepner merged 4 commits intomainfrom
miagilepner/events-namespace-forwarding

Conversation

@miagilepner
Copy link
Copy Markdown
Collaborator

Description

Fix redirects when a namespace is included in the namespace header, or for events when it's included in the path.
Fixes #27551.

TODO only if you're a HashiCorp employee

  • Labels: If this PR is the CE portion of an ENT change, and that ENT change is
    getting backported to N-2, use the new style backport/ent/x.x.x+ent labels
    instead of the old style backport/x.x.x labels.
  • Labels: If this PR is a CE only change, it can only be backported to N, so use
    the normal backport/x.x.x label (there should be only 1).
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@miagilepner miagilepner added this to the 1.18.0-rc milestone Jul 2, 2024
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 2, 2024
@miagilepner miagilepner requested review from ccapurso and tvoran July 2, 2024 14:10
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 2, 2024

Build Results:
All builds succeeded! ✅

@miagilepner miagilepner merged commit 9e299c2 into main Jul 3, 2024
@miagilepner miagilepner deleted the miagilepner/events-namespace-forwarding branch July 3, 2024 08:08
miagilepner added a commit that referenced this pull request Jul 3, 2024
* handle namespaced events redirects

* full test:

* changelog

* lint
miagilepner added a commit that referenced this pull request Jul 3, 2024
* handle namespaced events redirects

* full test:

* changelog

* lint

Co-authored-by: miagilepner <mia.epner@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subscribe to events notifications does not work on secondary nodes

3 participants