Skip to content

Backport of UI: remove renew self call after login into release/1.17.x#28208

Draft
hc-github-team-secure-vault-core wants to merge 1 commit intorelease/1.17.xfrom
backport/ui/VAULT-30473/fix-renew-self-after-login/explicitly-moving-shepherd
Draft

Backport of UI: remove renew self call after login into release/1.17.x#28208
hc-github-team-secure-vault-core wants to merge 1 commit intorelease/1.17.xfrom
backport/ui/VAULT-30473/fix-renew-self-after-login/explicitly-moving-shepherd

Conversation

@hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #28204 to be assessed for backporting due to the inclusion of the label backport/1.17.x.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@hashishaw
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

When logging in with a non-renewable token (such as root or batch), I was seeing that upon login the UI immediately triggered a renew-self call. I traced it back to this PR where we updated the batch token to also updates expirationTime even though it's not renewable. This caused setLastFetch to try to compare now to null, which caused it to always renew.

Batch token after login before
Screenshot 2024-08-27 at 16 36 01


Overview of commits

@hashicorp-cla-app
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 28, 2024
@github-actions
Copy link

CI Results:
All Go tests succeeded! ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants