Skip to content

Fix potential error revoking privileges in postgres secret engine #28519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fairclothjm merged 3 commits into from
Sep 26, 2024
Merged

Fix potential error revoking privileges in postgres secret engine #28519

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
facfb85
Fix potential error revoking privileges in postgres secret engine
lboynton Sep 26, 2024
24cd5a4
add changelog entry
lboynton Sep 26, 2024
fe53c7e
fix changelog format
fairclothjm Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/database/postgresql/postgresql.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ func (p *PostgreSQL) defaultDeleteUser(ctx context.Context, username string) err
}
revocationStmts = append(revocationStmts, fmt.Sprintf(
`REVOKE ALL PRIVILEGES ON ALL TABLES IN SCHEMA %s FROM %s;`,
(schema),
dbutil.QuoteIdentifier(schema),
Copy link
Copy Markdown
Contributor

@fairclothjm fairclothjm Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not so sure this is a straightforward change. Is this backwards compatible? It doesn't appear to be so based on http://www.postgresql.org/docs/9.2/static/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS

Quoting an identifier also makes it case-sensitive, whereas unquoted names are always folded to lower case.

So we might break users that depend on case-insensitivity.

Copy link
Copy Markdown
Contributor

@fairclothjm fairclothjm Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, it looks like we already quote the schema name in the next revoke call here: https://github.com/hashicorp/vault/blame/2db2a9fb5d890b213a2c05aa5698c63560399774/plugins/database/postgresql/postgresql.go#L537

Copy link
Copy Markdown
Contributor Author

@lboynton lboynton Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it used to be quoted but it was (unintentionally I guess) dropped in this PR: #15343

Copy link
Copy Markdown
Contributor

@fairclothjm fairclothjm Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do you mind adding a changelog entry?

changelog/28519.txt

database/postgresql: Fix potential error revoking privileges in postgresql database secrets engine when a schema contains special characters

Copy link
Copy Markdown
Contributor Author

@lboynton lboynton Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

dbutil.QuoteIdentifier(username)))

revocationStmts = append(revocationStmts, fmt.Sprintf(
Expand Down