Skip to content

Backport of UI: Fix oidc auth method missing default_role field into release/1.18.x#28551

Merged
hellobontempo merged 2 commits intorelease/1.18.xfrom
backport/ui/fix-missing-openapi-auth-params/multiply-saving-toucan
Oct 1, 2024
Merged

Backport of UI: Fix oidc auth method missing default_role field into release/1.18.x#28551
hellobontempo merged 2 commits intorelease/1.18.xfrom
backport/ui/fix-missing-openapi-auth-params/multiply-saving-toucan

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #28539 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

Fixes default_role missing from OIDC form. The field was accidentally removed when #27764 was implemented because auth-config/oidc was left out of the helper const. This happened because the model inherits from jwt making it easy to miss during the refactor. I added some test coverage for some of these open api models so it doesn't happen again

before

Screenshot 2024-09-30 at 4 09 41 PM

after

Screenshot 2024-09-30 at 4 08 56 PM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this PR is in the ENT repo and needs to be backported, backport
    to N, N-1, and N-2, using the backport/ent/x.x.x+ent labels. If this PR is in the CE repo, you should only backport to N, using the backport/x.x.x label, not the enterprise labels.
    • If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 1, 2024

Build Results:
All builds succeeded! ✅

@hellobontempo hellobontempo added this to the 1.18.0 milestone Oct 1, 2024
@hellobontempo hellobontempo enabled auto-merge (squash) October 1, 2024 16:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 1, 2024

CI Results:
All Go tests succeeded! ✅

@hellobontempo hellobontempo merged commit a48dbe0 into release/1.18.x Oct 1, 2024
@hellobontempo hellobontempo deleted the backport/ui/fix-missing-openapi-auth-params/multiply-saving-toucan branch October 1, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants