Add a max_crl_size parameter to CRL config#28654
Merged
Conversation
|
CI Results: |
|
Build Results: |
victorr
reviewed
Oct 9, 2024
Contributor
victorr
left a comment
There was a problem hiding this comment.
LGTM, I have left a suggestion.
Not approving right away to check whether there are docs that need to be updated.
Contributor
stevendpclark
left a comment
There was a problem hiding this comment.
Small nits, nothing preventing merging after api-docs are updated.
Contributor
stevendpclark
left a comment
There was a problem hiding this comment.
Looks great, just need to update the api-docs with the new field name.
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
Co-authored-by: Steven Clark <steven.clark@hashicorp.com>
…vault into sgm/vault-22664/max-crl-size
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If set or the default 100k, CRL building will fail if there are more than
that many entries in the CRL. It will also warn when within 10% of the
limit.
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.