Skip to content

UI: Remove kv data download button#29290

Merged
hellobontempo merged 2 commits intomainfrom
remove-kv-download-button
Jan 6, 2025
Merged

UI: Remove kv data download button#29290
hellobontempo merged 2 commits intomainfrom
remove-kv-download-button

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

@hellobontempo hellobontempo commented Jan 6, 2025

Description

Removing the ability to download a row of kv secret data (added by #20431) until we can implement this functionality in a way that can be gated by policy or admin configuration (requested by #23981)

Users can still copy or wrap secret data.
Screenshot 2025-01-06 at 9 07 03 AM

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.19.0-rc milestone Jan 6, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner January 6, 2025 15:08
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jan 6, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2025

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jan 6, 2025

CI Results:
All Go tests succeeded! ✅

Copy link
Copy Markdown
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@hellobontempo hellobontempo merged commit 6d566cb into main Jan 6, 2025
@hellobontempo hellobontempo deleted the remove-kv-download-button branch January 6, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed ui

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants