Skip to content

Add support for reloading raft config#29485

Merged
ncabatoff merged 7 commits intomainfrom
nc/reloadable-raft-config
Feb 5, 2025
Merged

Add support for reloading raft config#29485
ncabatoff merged 7 commits intomainfrom
nc/reloadable-raft-config

Conversation

@ncabatoff
Copy link
Copy Markdown
Collaborator

@ncabatoff ncabatoff commented Feb 3, 2025

Description

SIGHUP now reloads the raft configuration given in the storage stanza that is reloadable. sys/config/state/sanitized now includes the storage stanza settings.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2025

CI Results:
All Go tests succeeded! ✅

@ncabatoff ncabatoff marked this pull request as ready for review February 4, 2025 19:28
@ncabatoff ncabatoff requested a review from a team as a code owner February 4, 2025 19:28
@ncabatoff ncabatoff requested a review from VinnyHC February 4, 2025 19:28
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2025

Build Results:
All builds succeeded! ✅

Copy link
Copy Markdown
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some high-level comments and clarifying questions. I think this looks great and am personally excited to see this patch. Just want to make sure we're not overlooking some edge-cases.

Co-authored-by: Mike Palmiotto <mike.palmiotto@hashicorp.com>
Copy link
Copy Markdown
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ncabatoff ncabatoff enabled auto-merge (squash) February 5, 2025 14:53
@ncabatoff ncabatoff merged commit 38c3e15 into main Feb 5, 2025
89 of 90 checks passed
@ncabatoff ncabatoff deleted the nc/reloadable-raft-config branch February 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants