Skip to content

Backport of VAULT-33603: normalize start time in export api into release/1.18.x#29586

Merged
aslamovamir merged 1 commit intorelease/1.18.xfrom
backport/aslamovamir-hvt-33603-normalize-start-date-export/amazingly-nice-dassie
Feb 13, 2025
Merged

Backport of VAULT-33603: normalize start time in export api into release/1.18.x#29586
aslamovamir merged 1 commit intorelease/1.18.xfrom
backport/aslamovamir-hvt-33603-normalize-start-date-export/amazingly-nice-dassie

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #29562 to be assessed for backporting due to the inclusion of the label backport/1.18.x.

The below text is copied from the body of the original PR.


Description

What does this PR do?
The export API will return different results than the sys/counters API when using a date that is in the middle of the month; to fix this, we should normalize the start_date parameter to the start of the month as is done in the sys/counters API.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/aslamovamir-hvt-33603-normalize-start-date-export/amazingly-nice-dassie branch from b6c3533 to cfb5540 Compare February 12, 2025 20:16
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Feb 12, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@aslamovamir aslamovamir merged commit 06a3655 into release/1.18.x Feb 13, 2025
82 of 83 checks passed
@aslamovamir aslamovamir deleted the backport/aslamovamir-hvt-33603-normalize-start-date-export/amazingly-nice-dassie branch February 13, 2025 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants