Skip to content

Support reading mysql backend credentials from environment variables#30136

Merged
VioletHynes merged 2 commits intohashicorp:mainfrom
miles-w-3:feature/mysql-env-credentials
Apr 2, 2025
Merged

Support reading mysql backend credentials from environment variables#30136
VioletHynes merged 2 commits intohashicorp:mainfrom
miles-w-3:feature/mysql-env-credentials

Conversation

@miles-w-3
Copy link
Copy Markdown
Contributor

Description

Adds ability to read in mysql backend storage credentials from environment variables. Updates the documentation to support this, as well as correcting the plaintext_connection_allowed - it seems like plaintext_credentials_transmission has not been a part of the implementation for a while

@miles-w-3 miles-w-3 requested review from a team as code owners March 31, 2025 21:29
@miles-w-3 miles-w-3 requested a review from angelocordon March 31, 2025 21:29
@hashicorp-cla-app
Copy link
Copy Markdown

hashicorp-cla-app bot commented Mar 31, 2025

CLA assistant check
All committers have signed the CLA.

@hashicorp-cla-app
Copy link
Copy Markdown

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


Miles seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA.
If you have already a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@miles-w-3 miles-w-3 force-pushed the feature/mysql-env-credentials branch from 460cd11 to 7b81acf Compare March 31, 2025 21:32
VioletHynes
VioletHynes previously approved these changes Apr 1, 2025
Copy link
Copy Markdown
Contributor

@VioletHynes VioletHynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for the contribution. This looks good to me! It looks like you need to sign the CLA, and I'll also need an approval from the documentation team before I can merge this.

@VioletHynes
Copy link
Copy Markdown
Contributor

Oh, I'll also need you to add a changelog. This should be a file in changelogs called 30136.txt with something like the following text:

release-note:improvement
storage/mysql: Added support for getting username and password from the environment variables `VAULT_MYSQL_USERNAME` and `VAULT_MYSQL_PASSWORD`.

Feel free to look at the other ones in that folder for reference.

@miles-w-3 miles-w-3 force-pushed the feature/mysql-env-credentials branch 2 times, most recently from b0bfb08 to 1916644 Compare April 1, 2025 20:25
@miles-w-3
Copy link
Copy Markdown
Contributor Author

@VioletHynes thank you for the review, I have added the changelog file and rebased to get the latest from main.

@VioletHynes
Copy link
Copy Markdown
Contributor

VioletHynes commented Apr 1, 2025

@miles-w-3 you'll need to use triple backticks at the top and bottom of the changelog, e.g. 28121.txt might be a good example of what I mean. Apologies, it's hard to show the backticks on GitHub since they get construed as a codeblock.

Signed-off-by: Miles <miles.wilson@wolterskluwer.com>
@miles-w-3 miles-w-3 force-pushed the feature/mysql-env-credentials branch from 1916644 to 222fd41 Compare April 1, 2025 20:30
@miles-w-3
Copy link
Copy Markdown
Contributor Author

@VioletHynes My mistake, I should have looked at the other examples more closely. Should be fixed now, thanks.

@VioletHynes VioletHynes merged commit 9231f5d into hashicorp:main Apr 2, 2025
73 of 74 checks passed
@miles-w-3
Copy link
Copy Markdown
Contributor Author

@VioletHynes apologies for my lack of familiarity with the vault release process. I noticed that v1.19.1 came out a few days after this was merged and did not include this fix. Is there a standard timeline for when new features get included vs minor release bugfixes, or did I just miss the cutoff?

Thanks

@VioletHynes
Copy link
Copy Markdown
Contributor

Hi there! We don't generally backport new features or improvements, unfortunately, for a myriad of reasons. This will be released in 1.20. I know that might seem quite far away, and I do apologize for that, but that's unfortunately our standard practice to keep stability in dot releases.

@miles-w-3
Copy link
Copy Markdown
Contributor Author

That makes sense, thank you

hellobontempo pushed a commit that referenced this pull request May 21, 2025
…30136)

Signed-off-by: Miles <miles.wilson@wolterskluwer.com>
Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants