Support reading mysql backend credentials from environment variables#30136
Support reading mysql backend credentials from environment variables#30136VioletHynes merged 2 commits intohashicorp:mainfrom
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Miles seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
460cd11 to
7b81acf
Compare
VioletHynes
left a comment
There was a problem hiding this comment.
Hi there! Thanks for the contribution. This looks good to me! It looks like you need to sign the CLA, and I'll also need an approval from the documentation team before I can merge this.
|
Oh, I'll also need you to add a changelog. This should be a file in Feel free to look at the other ones in that folder for reference. |
b0bfb08 to
1916644
Compare
|
@VioletHynes thank you for the review, I have added the changelog file and rebased to get the latest from main. |
|
@miles-w-3 you'll need to use triple backticks at the top and bottom of the changelog, e.g. |
Signed-off-by: Miles <miles.wilson@wolterskluwer.com>
1916644 to
222fd41
Compare
|
@VioletHynes My mistake, I should have looked at the other examples more closely. Should be fixed now, thanks. |
|
@VioletHynes apologies for my lack of familiarity with the vault release process. I noticed that v1.19.1 came out a few days after this was merged and did not include this fix. Is there a standard timeline for when new features get included vs minor release bugfixes, or did I just miss the cutoff? Thanks |
|
Hi there! We don't generally backport new features or improvements, unfortunately, for a myriad of reasons. This will be released in 1.20. I know that might seem quite far away, and I do apologize for that, but that's unfortunately our standard practice to keep stability in dot releases. |
|
That makes sense, thank you |
…30136) Signed-off-by: Miles <miles.wilson@wolterskluwer.com> Co-authored-by: Violet Hynes <violet.hynes@hashicorp.com>
Description
Adds ability to read in mysql backend storage credentials from environment variables. Updates the documentation to support this, as well as correcting the
plaintext_connection_allowed- it seems likeplaintext_credentials_transmissionhas not been a part of the implementation for a while