[VAULT-35046] Show namespace count label by beagins · Pull Request #30183 · hashicorp/vault

beagins · 2025-04-04T00:37:41Z

Description

This branch is merging into a feature side branch (not `main`)

The current implementation looks ugly, styling will be addressed in a separate PR**

Replace Hds::SuperSelect with Hds::Dropdown component*
Show namespace count label: All/Matching Namespaces (#)
Enterprise tests passing ✅

236 tests completed in 174031 milliseconds, with 0 failed, 10 skipped, and 0 todo.
1433 assertions of 1433 passed, 0 failed.

* The SuperSelect component was limited in regards to implementing search across an array of objects instead of strings, and when displaying the namespace count label below the search field. The Dropdown component is more flexible, making it possible for the implementation to match the existing design.

Screenshots

TODO only if you're a HashiCorp employee

Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
- LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
Jira: If this change has an associated Jira, it's referenced either
in the PR description, commit message, or branch name.
RFC: If this change has an associated RFC, please link it in the description.
ENT PR: If this change has an associated ENT PR, please link it in the
description. Also, make sure the changelog is in this PR, not in your ENT PR.

github-actions · 2025-04-04T01:01:13Z

CI Results:
All Go tests succeeded! ✅

…f Hds::Superselect

github-actions · 2025-04-16T00:00:38Z

Build Results:
All builds succeeded! ✅

hellobontempo

Nice job! I know fiddling with a component for a while and abandoning it can be a rough journey. Now you'll be the SuperSelect expert on when to and not to use 😂

Most of the comments are just some funny ember things, just a couple questions about implementation. Looks great, though! 😄

ui/app/components/namespace-picker.js

ui/app/components/namespace-picker.hbs

ui/app/components/namespace-picker.js

ui/app/components/namespace-picker/title.hbs

ui/app/components/namespace-picker/title.ts

ui/app/components/namespace-picker.hbs

beagins · 2025-04-17T16:15:52Z

ui/app/components/namespace-picker.hbs

+    {{/each}}
+
+    {{! Check if the user has permissions to list namespaces. If true, display additional footer options like "Refresh list" and "Manage". }}
+    {{#if this.hasListPermissions}}


Note: The previous implementation of namespace picker hid both the Refresh & Manage buttons if the user did not have permissions to list namespaces. I kept this logic for now, but added a TODO in the component file to see if it makes sense to hide both buttons or only hide the Manage button.

I think the list one is un-gated, so everyone has access (it will just only return what a user can view) The permissions wrap should only apply to hide/showing manage

Just an FYI 😄 but definitely fine to address as a follow-on

ui/app/components/namespace-picker.js

ui/tests/acceptance/enterprise-namespaces-test.js

ui/app/components/namespace-picker.hbs

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

…pace count label (#30183) * [VAULT-35046] Show namespace count label; use Hds::Dropdown instead of Hds::Superselect * address misc pr comments * update tests * address PR comment * Update ui/app/components/namespace-picker.hbs Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> * Update ui/app/components/namespace-picker.hbs Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com> * address PR comments: update tests * use getter for namespace label --------- Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 4, 2025

beagins force-pushed the VAULT-34216/namespace-picker-feature-branch branch from 6c14cca to 25ee251 Compare April 15, 2025 21:16

beagins force-pushed the VAULT-34216/namespace-count branch from 2af01e4 to 7e4dea9 Compare April 15, 2025 21:17

beagins force-pushed the VAULT-34216/namespace-picker-feature-branch branch from 25ee251 to bf374ec Compare April 15, 2025 23:12

[VAULT-35046] Show namespace count label; use Hds::Dropdown instead o…

03ae355

…f Hds::Superselect

beagins force-pushed the VAULT-34216/namespace-count branch from 7e4dea9 to 03ae355 Compare April 15, 2025 23:14

beagins marked this pull request as ready for review April 15, 2025 23:56

beagins requested a review from a team as a code owner April 15, 2025 23:56

hellobontempo reviewed Apr 16, 2025

View reviewed changes

lane-wetmore added ui and removed ui labels Apr 16, 2025

beagins added 3 commits April 16, 2025 11:51

address misc pr comments

dceee97

update tests

39c53f1

address PR comment

d72e903

beagins commented Apr 17, 2025

View reviewed changes

Monkeychip reviewed Apr 17, 2025

View reviewed changes

ui/app/components/namespace-picker.js Outdated Show resolved Hide resolved

Monkeychip reviewed Apr 17, 2025

View reviewed changes

ui/tests/acceptance/enterprise-namespaces-test.js Outdated Show resolved Hide resolved

hellobontempo reviewed Apr 17, 2025

View reviewed changes

ui/app/components/namespace-picker.hbs Outdated Show resolved Hide resolved

hellobontempo reviewed Apr 17, 2025

View reviewed changes

ui/app/components/namespace-picker.hbs Outdated Show resolved Hide resolved

beagins and others added 2 commits April 17, 2025 10:26

Update ui/app/components/namespace-picker.hbs

a52c5a8

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

Update ui/app/components/namespace-picker.hbs

16d8255

Co-authored-by: claire bontempo <68122737+hellobontempo@users.noreply.github.com>

hellobontempo approved these changes Apr 17, 2025

View reviewed changes

beagins added 2 commits April 17, 2025 17:08

address PR comments: update tests

7c3575c

use getter for namespace label

302873c

beagins merged this pull request into VAULT-34216/namespace-picker-feature-branch Apr 18, 2025
25 checks passed

beagins deleted the VAULT-34216/namespace-count branch April 18, 2025 01:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[VAULT-35046] Show namespace count label#30183

[VAULT-35046] Show namespace count label#30183
beagins merged 8 commits intoVAULT-34216/namespace-picker-feature-branchfrom
VAULT-34216/namespace-count

beagins commented Apr 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 4, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

hellobontempo left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beagins Apr 17, 2025 •

edited

Loading

Uh oh!

hellobontempo Apr 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

beagins commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

TODO only if you're a HashiCorp employee

Uh oh!

github-actions bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 16, 2025

Uh oh!

hellobontempo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beagins Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hellobontempo Apr 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

beagins commented Apr 4, 2025 •

edited

Loading

github-actions bot commented Apr 4, 2025 •

edited

Loading

beagins Apr 17, 2025 •

edited

Loading