Merged
Conversation
Update the changelog for beginning of April releases
github-actions
bot
added
the
hashicorp-contributed-pr
|
CI Results: |
|
Build Results: |
ldilalla-HC
approved these changes
Apr 4, 2025
anwittin
requested changes
Apr 4, 2025
Collaborator
anwittin
left a comment
anwittin
left a comment
There was a problem hiding this comment.
A couple of nits and one item missing?
| IMPROVEMENTS: | ||
|
|
||
| * activity: mount_type was added to the API response of sys/internal/counters/activity [[GH-30071](https://github.com/hashicorp/vault/pull/30071)] | ||
| * activity: mount_type was added to the API response of sys/internal/counters/activity |
Collaborator
There was a problem hiding this comment.
This looks like a duplicate?
| * core: Fix a bug that prevents certain loggers from writing to a log file. [[GH-29917](https://github.com/hashicorp/vault/pull/29917)] | ||
| * plugins (enterprise): Fix plugin registration with artifact when a binary for the same plugin is already present in the plugin directory. | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config [[GH-29978](https://github.com/hashicorp/vault/pull/29978)] | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config |
Collaborator
There was a problem hiding this comment.
Is this also a duplicate?
| * export API: Normalize the start_date parameter to the start of the month as is done in the sys/counters API to keep the results returned from both of the API's consistent. | ||
| * plugins (enterprise): Fix plugin registration with artifact when a binary for the same plugin is already present in the plugin directory. | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config [[GH-29978](https://github.com/hashicorp/vault/pull/29978)] | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config |
| * export API: Normalize the start_date parameter to the start of the month as is done in the sys/counters API to keep the results returned from both of the API's consistent. | ||
| * plugins (enterprise): Fix plugin registration with artifact when a binary for the same plugin is already present in the plugin directory. | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config [[GH-29978](https://github.com/hashicorp/vault/pull/29978)] | ||
| * plugins: plugin registration should honor the `plugin_tmpdir` config |
Contributor
Author
There was a problem hiding this comment.
Yeah, makes sense, duplicate entries that got backported the whole way.
| * auth/ldap: Fix a bug that does not properly delete users and groups by first converting their names to lowercase when case senstivity option is off. [[GH-29922](https://github.com/hashicorp/vault/pull/29922)] | ||
| * core: Fix Azure authentication for seal/managed keys to work for both federated workload identity and managed user identities. Fixes regression for federated workload identities. [[GH-29792](https://github.com/hashicorp/vault/pull/29792)] | ||
| * core: Fix a bug that prevents certain loggers from writing to a log file. [[GH-29917](https://github.com/hashicorp/vault/pull/29917)] | ||
| * export API: Normalize the start_date parameter to the start of the month as is done in the sys/counters API to keep the results returned from both of the API's consistent. |
Collaborator
There was a problem hiding this comment.
This one is missing from 1.19 and 1.18. It looks like the backport labels were incorrectly added. not sure what we want to do here? #29562
Contributor
Author
There was a problem hiding this comment.
The CE & ENT PRs for this change were released in 1.19.0 and 1.18.5, then only the ENT PRs in 1.16.18 and 1.17.14. @akshya96 can you take a look and make sure everything is where it should be?
hellobontempo
pushed a commit
that referenced
this pull request
May 21, 2025
Update the changelog for beginning of April releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the changelog for beginning of April releases.
Reference Jira: VAULT-35203
Description
What does this PR do?
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.