Add max_parallel to mssql and postgresql#3026
Merged
Conversation
For storage backends, set max open connections to value of max_parallel.
briankassouf
approved these changes
Jul 17, 2017
Contributor
briankassouf
left a comment
briankassouf
left a comment
There was a problem hiding this comment.
Two small comments, otherwise looks good!
| if logger.IsDebug() { | ||
| logger.Debug("couchdb: max_parallel set", "max_parallel", maxParInt) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Should there be an else here to set the default?
Member
Author
There was a problem hiding this comment.
There can be, but since we don't call the sql function to set the max open connections, it's unnecessary (using 0 will, for the permit pool, use the default anyways).
| defer metrics.MeasureSince([]string{"couchdb", "list"}, time.Now()) | ||
|
|
||
| m.permitPool.Acquire() | ||
| defer m.permitPool.Release() |
Contributor
There was a problem hiding this comment.
Should put and delete use the permit pool too?
Member
Author
There was a problem hiding this comment.
They already do! List didn't for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For storage backends, set max open connections to value of max_parallel.