Skip to content

Rename EntCoreConfig to lowercase to preserve encapsulation#30286

Merged
aslamovamir merged 2 commits intomainfrom
aslamovamir-fix-encapsulation-ent-config-oss
Apr 21, 2025
Merged

Rename EntCoreConfig to lowercase to preserve encapsulation#30286
aslamovamir merged 2 commits intomainfrom
aslamovamir-fix-encapsulation-ent-config-oss

Conversation

@aslamovamir
Copy link
Copy Markdown
Contributor

@aslamovamir aslamovamir commented Apr 17, 2025

Description

What does this PR do?
This PR preserves encapsulation associated with entCoreConfig by renaming it to lowercase. This was previously broken by a past PR which capitalized this struct.

Associated ENT PR: https://github.com/hashicorp/vault-enterprise/pull/7895
Past PR that broke the encapsulation on OSS: #29562

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 17, 2025
@aslamovamir aslamovamir marked this pull request as ready for review April 17, 2025 19:25
@aslamovamir aslamovamir requested a review from a team as a code owner April 17, 2025 19:25
@aslamovamir aslamovamir requested a review from MooCohen April 17, 2025 19:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 17, 2025

CI Results:
All Go tests succeeded! ✅

@aslamovamir aslamovamir requested review from akshya96 and mpalmi April 17, 2025 19:26
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@aslamovamir aslamovamir merged commit 766f97a into main Apr 21, 2025
95 of 97 checks passed
@aslamovamir aslamovamir deleted the aslamovamir-fix-encapsulation-ent-config-oss branch April 21, 2025 20:10
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants