Skip to content

Backport of bugfix: vault register should respect tmpdir into release/1.19.x#30392

Merged
raymonstah merged 1 commit intorelease/1.19.xfrom
backport/raymond/VAULT-34604/bugfix-vault-register-tmpdir/similarly-dominant-wasp
Apr 25, 2025
Merged

Backport of bugfix: vault register should respect tmpdir into release/1.19.x#30392
raymonstah merged 1 commit intorelease/1.19.xfrom
backport/raymond/VAULT-34604/bugfix-vault-register-tmpdir/similarly-dominant-wasp

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #29978 to be assessed for backporting due to the inclusion of the label backport/1.19.x.

The below text is copied from the body of the original PR.


Description

When running Vault via systemd and PrivateTmp=on, the Vault register command fails, even when setting the VAULT_PLUGIN_TMPDIR environment variable:

ubuntu@ip-172-25-19-239:~$ vault plugin register -sha256="${SHA256}" -oci_image=hashicorp/vault-plugin-secrets-kv secret my-kv-container
WARNING! VAULT_ADDR and -address unset. Defaulting to https://127.0.0.1:8200/.
Error registering plugin my-kv-container: Error making API request.

URL: PUT https://127.0.0.1:8200/v1/sys/plugins/catalog/secret/my-kv-container
Code: 400. Errors:

* unable to run plugin: 1 error occurred:
        * error creating container: Error response from daemon: invalid mount config for type "bind": bind source path does not exist: /tmp/plugin-dir3781501367
        *

This change makes it so that the register flow respects the tmpdir, if set.

With this change, the output looks like:

vault plugin register -sha256="${SHA256}" -oci_image=hashicorp/vault-plugin-secrets-kv  secret my-kv-container
WARNING! VAULT_ADDR and -address unset. Defaulting to https://127.0.0.1:8200.
Success! Registered plugin: my-kv-container

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

Overview of commits

@hc-github-team-secure-vault-core hc-github-team-secure-vault-core force-pushed the backport/raymond/VAULT-34604/bugfix-vault-register-tmpdir/similarly-dominant-wasp branch from 78f0b7c to 73e333d Compare April 25, 2025 16:25
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Apr 25, 2025
@raymonstah raymonstah added this to the 1.19.3 milestone Apr 25, 2025
@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@raymonstah raymonstah merged commit b8c33ad into release/1.19.x Apr 25, 2025
84 of 86 checks passed
@raymonstah raymonstah deleted the backport/raymond/VAULT-34604/bugfix-vault-register-tmpdir/similarly-dominant-wasp branch April 25, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants