[VAULT-35780] address TODOs#30468
[VAULT-35780] address TODOs#30468beagins merged 8 commits intoVAULT-34216/namespace-picker-feature-branchfrom
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
There was a problem hiding this comment.
🗒️ Note: traced this back to this PR. The test in question was added to verify that the namespace picker works whether the user logs in with '/namespace' or 'namespace'. The namespace service strips out any prefixed '/', so option?.path will not have a proceeding '/'. We still have an enterprise test to ensure that the namespace picker works whether the user logs in w/ a '/' prefixed namespace or not.
beagins
force-pushed
the
VAULT-34216/address-todos
branch
from
25d7b7f to
df29600
Compare
|
CI Results: |
beagins
force-pushed
the
VAULT-34216/address-todos
branch
from
df29600 to
b31623d
Compare
|
Build Results: |
beagins
force-pushed
the
VAULT-34216/namespace-picker-feature-branch
branch
from
7af7cf4 to
ba2237f
Compare
beagins
requested review from
a team and
prakashlinga
and removed request for
a team
beagins
force-pushed
the
VAULT-34216/address-todos
branch
from
3371445 to
f59945f
Compare
There was a problem hiding this comment.
🗒️ Note: This test case is now covered by the three new tests added above:
test('it shows both action buttons when canList is true', async function (assert) {
test('it hides the refresh button when canList is false', async function (assert) {
test('it hides both action buttons when the capabilities store throws an error', async function (assert) {
ba2237f to
78bed19
Compare
beagins
force-pushed
the
VAULT-34216/address-todos
branch
from
c382d0f to
3d3b4a5
Compare
| <D.ToggleButton @icon="org" @text={{or this.selected.id "-"}} @isFullWidth={{true}} data-test-namespace-toggle /> | ||
|
|
||
| <D.Header> | ||
| {{#if this.errorLoadingNamespaces}} |
There was a problem hiding this comment.
awesome to see we're displaying the error
| import { login, loginNs, logout } from 'vault/tests/helpers/auth/auth-helpers'; | ||
| import { AUTH_FORM } from 'vault/tests/helpers/auth/auth-form-selectors'; | ||
| import { GENERAL } from '../helpers/general-selectors'; | ||
| import { NAMESPACE_PICKER_SELECTORS } from '../helpers/namespace-picker'; |
There was a problem hiding this comment.
Up to you, but I like to shorten then. For Secret Engine Selectors I used SES, or maybe here just NAMESPACE_PICKER. Shortening it saves the smallest amount of time when typing these out, those co-pilot kind of does it for you. Again, totally up to you.
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Really great job on this!
beagins
merged commit bc03e54
into
VAULT-34216/namespace-picker-feature-branch
* [VAULT-35780] address TODOs * wrap manage & refresh buttons in Hds::ButtonSet * fix failing integration tests * remove unnecessary import mirage * fix undefined * fix flaky tests * styling updates * don't show search help text when there are no namespaces matching the search criteria
2 participants
Description
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.