Skip to content

fix panic in HCL duplicate warning#30780

Merged
bosouza merged 1 commit intomainfrom
bosouza/fix-hcl-bug
May 29, 2025
Merged

fix panic in HCL duplicate warning#30780
bosouza merged 1 commit intomainfrom
bosouza/fix-hcl-bug

Conversation

@bosouza
Copy link
Copy Markdown
Contributor

@bosouza bosouza commented May 28, 2025

Description

#30386 introduced a bug where the new HCL duplicate attribute warning on policy creation would cause a panic. Tests didn't catch it because they were triggering a different warning path that already had this logic. Thanks @mpalmi for finding the issue!

TODO only if you're a HashiCorp employee

  • [-] Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • [-] LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • [-] ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • [-] Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • [-] RFC: If this change has an associated RFC, please link it in the description.
  • [-] ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@bosouza bosouza requested a review from mpalmi May 28, 2025 21:06
@bosouza bosouza requested a review from a team as a code owner May 28, 2025 21:06
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label May 28, 2025
@github-actions
Copy link
Copy Markdown

Build Results:
All builds succeeded! ✅

@github-actions
Copy link
Copy Markdown

CI Results:
All Go tests succeeded! ✅

@bosouza bosouza added this to the 1.20.0-rc milestone May 29, 2025
@bosouza bosouza merged commit 881a188 into main May 29, 2025
97 of 99 checks passed
@bosouza bosouza deleted the bosouza/fix-hcl-bug branch May 29, 2025 13:28
drivera258 pushed a commit that referenced this pull request Jun 4, 2025
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants