UI: Fixes issue where backup tab was selected if they included default type#30805
Merged
hellobontempo merged 2 commits intomainfrom Jun 2, 2025
Merged
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
hellobontempo
commented
Jun 2, 2025
| // In rare cases, pre-toggle the form to the fallback dropdown if the selected method is not in the alternate view. | ||
| // This could happen if tabs render for visible mounts and the "with" query param references a type that isn't a tab. | ||
| // Or auth type is preset from canceled MFA or local storage and is not in the default view. | ||
| const showAlternate = (authIsNotDefaultTab && hasAlternateView) || authIsAlternateTab; |
Contributor
Author
There was a problem hiding this comment.
essentially the fix was to update this conditional to:
(authIsNotDefaultTab && hasAlternateView) || (authIsAlternateTab && authIsNotDefaultTab);So I consolidated and simplified the logic by pulling out authIsNotDefaultTab
|
Build Results: |
hellobontempo
commented
Jun 2, 2025
| .dom(GENERAL.emptyStateMessage) | ||
| .hasText( | ||
| 'Login rules can be used to select default and back up login methods and customize which methods display in the web UI login form. Available to be created via the CLI or HTTP API.' | ||
| 'Login settings can be used to customize which methods display in the web UI login form by setting a default and back up login methods. Available to be created via the CLI or HTTP API.' |
Contributor
Author
There was a problem hiding this comment.
|
CI Results: |
hellobontempo
changed the title
hellobontempo
changed the title
Contributor
Author
|
Monkeychip
approved these changes
Jun 2, 2025
hellobontempo
deleted the
VAULT-36713/render-default-view-if-backup-types-include-default
branch
drivera258
pushed a commit
that referenced
this pull request
Jun 4, 2025
…t type (#30805) * Fixes issue where backup tab was selected if backups include default type * fix enterprise empty state assertion
drivera258
pushed a commit
that referenced
this pull request
Jun 11, 2025
…t type (#30805) * Fixes issue where backup tab was selected if backups include default type * fix enterprise empty state assertion
Erfankam
pushed a commit
to Erfankam/vault
that referenced
this pull request
Sep 1, 2025
…t type (hashicorp#30805) * Fixes issue where backup tab was selected if backups include default type * fix enterprise empty state assertion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
No changelog because follow-on to #30700
Fixes a bug where the form rendered the alternate view (backup tabs) if
backup_auth_typesincludeddefault_auth_type.Now the form properly renders the default (initial) view and does not pre-toggle the form.
initial view before fix
initial view after fix
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.