Skip to content

UI: Update namespace key to namespace_path#30848

Merged
hellobontempo merged 6 commits intomainfrom
custom-login-update-namespace-param
Jun 5, 2025
Merged

UI: Update namespace key to namespace_path#30848
hellobontempo merged 6 commits intomainfrom
custom-login-update-namespace-param

Conversation

@hellobontempo
Copy link
Copy Markdown
Contributor

@hellobontempo hellobontempo commented Jun 4, 2025

Description

Frontend compliment to https://github.com/hashicorp/vault-enterprise/pull/8211

No changelog because follow-on to #30700

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

@hellobontempo hellobontempo added this to the 1.20.0-rc milestone Jun 4, 2025
@hellobontempo hellobontempo requested a review from a team as a code owner June 4, 2025 18:42
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jun 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

Build Results:
All builds succeeded! ✅

@@ -22,6 +23,13 @@ module('Acceptance | Enterprise | config-ui/login-settings', function (hooks) {
setupMirage(hooks);

hooks.beforeEach(async function () {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome comment!

@hellobontempo
Copy link
Copy Markdown
Contributor Author

Screenshot 2025-06-05 at 3 52 15 PM

@hellobontempo hellobontempo merged commit 2feeaa9 into main Jun 5, 2025
32 of 33 checks passed
@hellobontempo hellobontempo deleted the custom-login-update-namespace-param branch June 5, 2025 19:52
hellobontempo added a commit that referenced this pull request Jun 5, 2025
* change namespace to namespace_path

* VAULT-36846 link jira

* update login settings tests

* fix details param

* update namespace param

* add comment
davidadeleon pushed a commit that referenced this pull request Jun 5, 2025
* change namespace to namespace_path

* VAULT-36846 link jira

* update login settings tests

* fix details param

* update namespace param

* add comment
drivera258 pushed a commit that referenced this pull request Jun 11, 2025
* change namespace to namespace_path

* VAULT-36846 link jira

* update login settings tests

* fix details param

* update namespace param

* add comment
Erfankam pushed a commit to Erfankam/vault that referenced this pull request Sep 1, 2025
* change namespace to namespace_path

* VAULT-36846 link jira

* update login settings tests

* fix details param

* update namespace param

* add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants