Skip to content

Backport of Fix missing dependencies in enos workflow for raft node removal into release/1.20.x#31448

Merged
brewgator merged 1 commit intorelease/1.20.xfrom
backport/lt/flaky-unseal-tests/apparently-amusing-mullet
Aug 7, 2025
Merged

Backport of Fix missing dependencies in enos workflow for raft node removal into release/1.20.x#31448
brewgator merged 1 commit intorelease/1.20.xfrom
backport/lt/flaky-unseal-tests/apparently-amusing-mullet

Conversation

@hc-github-team-secure-vault-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #31446 to be assessed for backporting due to the inclusion of the label backport/1.20.x.

The below text is copied from the body of the original PR.


Description

This PR fixes missing dependencies in the enos workflow during raft node removal operations. After removing a raft node, we run an unseal test that is expected to fail, but we were not requiring this test to complete before re-adding the node back to the cluster. This could cause race conditions where nodes are re-added before we've properly validated the expected unseal failure.

The fix adds the missing test dependency to ensure the unseal failure test runs and completes before proceeding with node re-addition. This dependency was previously missing but is necessary for reliable test sequencing and proper validation of the expected behavior.

TODO only if you're a HashiCorp employee

  • Backport Labels: If this fix needs to be backported, use the appropriate backport/ label that matches the desired release branch. Note that in the CE repo, the latest release branch will look like backport/x.x.x, but older release branches will be backport/ent/x.x.x+ent.
    • LTS: If this fixes a critical security vulnerability or severity 1 bug, it will also need to be backported to the current LTS versions of Vault. To ensure this, use all available enterprise labels.
  • ENT Breakage: If this PR either 1) removes a public function OR 2) changes the signature
    of a public function, even if that change is in a CE file, double check that
    applying the patch for this PR to the ENT repo and running tests doesn't
    break any tests. Sometimes ENT only tests rely on public functions in CE
    files.
  • Jira: If this change has an associated Jira, it's referenced either
    in the PR description, commit message, or branch name.
  • RFC: If this change has an associated RFC, please link it in the description.
  • ENT PR: If this change has an associated ENT PR, please link it in the
    description. Also, make sure the changelog is in this PR, not in your ENT PR.

PCI review checklist

  • I have documented a clear reason for, and description of, the change I am making.
  • If applicable, I've documented a plan to revert these changes if they require more than reverting the pull request.
  • If applicable, I've documented the impact of any changes to security controls.

Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.


Overview of commits

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2025

You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes.

Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles

@vercel
Copy link
Copy Markdown

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 4:50pm

@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Aug 7, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2025

CI Results:
All Go tests succeeded! ✅

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 7, 2025

Build Results:
All builds succeeded! ✅

@brewgator brewgator merged commit 168629e into release/1.20.x Aug 7, 2025
55 of 58 checks passed
@brewgator brewgator deleted the backport/lt/flaky-unseal-tests/apparently-amusing-mullet branch August 7, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog pr/no-milestone

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants