Backport of Fix missing dependencies in enos workflow for raft node removal into release/1.20.x#31448
Merged
brewgator merged 1 commit intorelease/1.20.xfrom Aug 7, 2025
Conversation
6fa12e7 to
0037ed2
Compare
|
You must have Developer access to commit code to HashiCorp on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
CI Results: |
|
Build Results: |
brewgator
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #31446 to be assessed for backporting due to the inclusion of the label backport/1.20.x.
The below text is copied from the body of the original PR.
Description
This PR fixes missing dependencies in the enos workflow during raft node removal operations. After removing a raft node, we run an unseal test that is expected to fail, but we were not requiring this test to complete before re-adding the node back to the cluster. This could cause race conditions where nodes are re-added before we've properly validated the expected unseal failure.
The fix adds the missing test dependency to ensure the unseal failure test runs and completes before proceeding with node re-addition. This dependency was previously missing but is necessary for reliable test sequencing and proper validation of the expected behavior.
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.
Overview of commits