Skip to content

FE-821: add menu to ds#8833

Merged
alex-e-leon merged 61 commits into
mainfrom
FE-821-add-menu-to-ds
Jun 8, 2026
Merged

FE-821: add menu to ds#8833
alex-e-leon merged 61 commits into
mainfrom
FE-821-add-menu-to-ds

Conversation

@alex-e-leon
Copy link
Copy Markdown
Contributor

@alex-e-leon alex-e-leon commented Jun 6, 2026

🌟 What is the purpose of this PR?

Adds menu component to design system

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c810234. Configure here.

Copy link
Copy Markdown
Contributor

@lunelson lunelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I notice in Ladle I can't actually "check" the kitchen sink checkbox... clicking it closes the menu without changing its checked state

@alex-e-leon alex-e-leon added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit d0af60d Jun 8, 2026
47 checks passed
@alex-e-leon alex-e-leon deleted the FE-821-add-menu-to-ds branch June 8, 2026 10:32
@hash-worker hash-worker Bot mentioned this pull request Jun 8, 2026
@alex-e-leon
Copy link
Copy Markdown
Contributor Author

Looks good, although I notice in Ladle I can't actually "check" the kitchen sink checkbox... clicking it closes the menu without changing its checked state

Good catch - I'll clean up some of the stories in the next PR or 2.

This was referenced Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash.design Affects the `hash.design` design site (app) area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants