Improve the docs for layoutSmart's fitting predicate#145
Merged
Conversation
Collaborator
Author
|
@quchen, @1Jajen1: A review would be much appreciated! :) I'm not very convinced of my clarity of expression, so any suggestions for improvement are welcome! @phadej Since these comments were taken from |
quchen
approved these changes
Feb 3, 2020
| -- 2. In that case the layout of a particular part of a document would | ||
| -- depend on the fit of completely unrelated parts of the same document. | ||
| -- See https://github.com/quchen/prettyprinter/issues/83 for a related | ||
| -- bug. |
| -- 'layoutPretty' will check only line 1, ignoring whether e.g. line 2 might | ||
| -- already be too wide. | ||
| -- By contrast, 'layoutSmart' stops only once it reaches line 4, where the @B@ | ||
| -- has the same indentation as the first @A@. |
Collaborator
There was a problem hiding this comment.
This is way more helpful than the original, good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136.