Skip to content

Support tar 0.7 #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ysangkok merged 2 commits into from
Jan 9, 2026
Merged

Support tar 0.7 #1449

ysangkok merged 2 commits into from
Jan 9, 2026

Conversation

@spencerjanssen
Copy link
Contributor

@spencerjanssen spencerjanssen commented Jan 5, 2026

Resolves #1430

@Bodigrim
Copy link
Contributor

Bodigrim commented Jan 5, 2026

If we want to gain benefits regarding file descriptors exhaustion, we need to replace Tar.write $ Tar.pack ... with Tar.write' $ Tar.pack' ... (for example, in exes/BuildClient.hs) and generally avoid both functions. But we can merge this as the first step as well, just to get tar-0.7 into the build plan.

@spencerjanssen
Support tar 0.7
f19dffb 
Resolves haskell#1430
@spencerjanssen
Use Tar.pack' and Tar.write'
13c5b51 
This prevents potential file descriptor exhaustion issues.
@spencerjanssen
Copy link
Contributor Author

spencerjanssen commented Jan 6, 2026

Fixed the Nix build, CI should pass now.

Addressed the two instances of Tar.write . Tar.pack I could find. As far as I can tell, the other instances of Tar.write don't have this particular file descriptor exhaustion issue.

@ysangkok ysangkok merged commit 774d7ba into haskell:master Jan 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bodigrim Bodigrim Bodigrim approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support tar-0.7.0.0

3 participants

@spencerjanssen @Bodigrim @ysangkok