Skip to content

Remove deprecated codenotary fields#503

Merged
frenck merged 1 commit intomainfrom
frenck-2025-0554
Nov 22, 2025
Merged

Remove deprecated codenotary fields#503
frenck merged 1 commit intomainfrom
frenck-2025-0554

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Nov 22, 2025

Proposed Changes

SSIA

Summary by CodeRabbit

  • Chores
    • Removed code notary verification settings from configuration.

✏️ Tip: You can customize this high-level summary in your review settings.

@frenck frenck added the bugfix Inconsistencies or issues which will cause a problem for users or implementors. label Nov 22, 2025
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Nov 22, 2025

Walkthrough

Codenotary configuration settings are removed from grocy's build and config files. The codenotary block with base_image and signer fields is deleted from build.yaml, and the codenotary field is removed from config.yaml.

Changes

Cohort / File(s) Summary
Codenotary configuration removal
grocy/build.yaml, grocy/config.yaml
Removed codenotary configuration block from build.yaml (base_image and signer fields) and removed codenotary field from config.yaml

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A config cleanup, simple and neat,
Codenotary fades, makes the change complete,
No logic to twist, just lines to remove,
A little refactor to keep things in groove! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Remove deprecated codenotary fields' directly and clearly matches the changeset, which removes codenotary configuration from both build.yaml and config.yaml files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch frenck-2025-0554

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73ff42b and b218b1a.

📒 Files selected for processing (2)
  • grocy/build.yaml (0 hunks)
  • grocy/config.yaml (0 hunks)
💤 Files with no reviewable changes (2)
  • grocy/config.yaml
  • grocy/build.yaml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@frenck frenck merged commit 981bbb6 into main Nov 22, 2025
22 checks passed
@frenck frenck deleted the frenck-2025-0554 branch November 22, 2025 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Nov 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Inconsistencies or issues which will cause a problem for users or implementors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant