Add support for changing GrocyCode type#513
Add support for changing GrocyCode type#513lazytarget wants to merge 2 commits intohassio-addons:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis PR introduces a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@grocy/rootfs/etc/s6-overlay/s6-rc.d/php-fpm/run`:
- Line 9: The script declares an unused shell variable grocycode_type and
assigns GROCY_GROCYCODE_TYPE without exporting it so php-fpm82 won't see it;
remove the unused declare grocycode_type and change the assignment to export
GROCY_GROCYCODE_TYPE (match the pattern used for
GROCY_CULTURE/GROCY_CURRENCY/GROCY_ENTRY_PAGE) so the environment variable is
exported into the php-fpm82 process.
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions. |
|
For anyone else looking for this feature right now. have setup my own Home Assistant repostory and forked this Grocy integration. Grocy add-on fork:
Repos: |
|
@lazytarget that is awesome, if one would want to migrate the data, do you happen to know how to do it? |
@valadas Could you try following this guide? Might be a little complicated depending on skill set. |
|
@lazytarget thanks for the detailed instructions. I first had to do a lot of upgrades to HA to even be able to add the repository. Then I could not find any folders in |
Fantastic! So glad I could help ❤️ Just out of interest and potentially for other users, why did you have an issue to add the repo? |
|
Oh boy I can't remember the exact version but it was at least 2 years old (home assistant OS and Core) and the issue was not specific to this repo, I also had it with the Portainer repo. It said something along the lines of not being able to add it due to OS minimum requirements or something something. |
Proposed Changes
Related Issues
Summary by CodeRabbit
New Features
Documentation