fix: Unity busy detection no longer relies on obsolete lock files

Assets/Tests/Editor/CompilationLockFileServiceTests.cs

@@ -19,7 +19,6 @@ public void SetUp()
         [TearDown]
         public void TearDown()
         {
-            _service.DeleteLockFile();
             _stateStore.Delete();
         }
 

Assets/Tests/Editor/DomainReloadDetectionServiceTests.cs

@@ -24,21 +24,20 @@ public void SetUp()
             _stateStore = CreateTestStateStore();
             _domainReloadDetectionService = new DomainReloadDetectionFileService(_editorSettingsService, _stateStore);
             UnityCliLoopEditorDomainReloadStateProvider.SetDomainReloadInProgressFromMainThread(false);
-            _domainReloadDetectionService.DeleteLockFile();
         }
 
         [TearDown]
         public void TearDown()
         {
             _editorSettingsService.SaveSettings(_originalSettings);
             UnityCliLoopEditorDomainReloadStateProvider.SetDomainReloadInProgressFromMainThread(false);
-            _domainReloadDetectionService.DeleteLockFile();
             _stateStore.Delete();
         }
 
         [Test]
-        public void RollbackDomainReloadStart_ClearsTemporaryFlagsProviderStateAndLockFile()
+        public void RollbackDomainReloadStart_ClearsTemporaryFlagsProviderStateAndPublishesFailureState()
         {
+            // Verifies rollback clears transient reload state and records a failed readiness phase.
             const string correlationId = "test-correlation";
             UnityCliLoopEditorDomainReloadStateProvider provider = new();
 
@@ -52,7 +51,6 @@ public void RollbackDomainReloadStart_ClearsTemporaryFlagsProviderStateAndLockFi
             Assert.That(startedSettings.showReconnectingUI, Is.True);
             Assert.That(startedSettings.showPostCompileReconnectingUI, Is.True);
             Assert.That(provider.IsDomainReloadInProgress(), Is.True);
-            Assert.That(_domainReloadDetectionService.IsLockFilePresent(), Is.True);
 
             _domainReloadDetectionService.RollbackDomainReloadStart(correlationId);
 
@@ -64,7 +62,9 @@ public void RollbackDomainReloadStart_ClearsTemporaryFlagsProviderStateAndLockFi
             Assert.That(rolledBackSettings.showReconnectingUI, Is.False);
             Assert.That(rolledBackSettings.showPostCompileReconnectingUI, Is.False);
             Assert.That(provider.IsDomainReloadInProgress(), Is.False);
-            Assert.That(_domainReloadDetectionService.IsLockFilePresent(), Is.False);
+            ServerReadinessState state = _stateStore.Read();
+            Assert.That(state.Phase, Is.EqualTo("failed"));
+            Assert.That(state.LastError, Is.Not.Empty);
         }
 
         private static UnityCliLoopEditorSettingsData CloneSettings(UnityCliLoopEditorSettingsData settings)

Assets/Tests/Editor/DomainReloadRecoveryUseCaseTests.cs

@@ -44,8 +44,6 @@ public void TearDown()
                 showPostCompileReconnectingUI = false
             });
 
-            // Clean up lock file created by ExecuteBeforeDomainReload
-            _domainReloadDetectionService.DeleteLockFile();
             _stateStore.Delete();
         }
 
@@ -118,7 +116,6 @@ public void CompleteDomainReload_WhenServerWasNotRunning_ShouldPublishStoppedSta
 
             ServerReadinessState state = _stateStore.Read();
             Assert.That(state.Phase, Is.EqualTo("stopped"));
-            Assert.That(_domainReloadDetectionService.IsLockFilePresent(), Is.False);
         }
 
         [Test]
@@ -188,7 +185,7 @@ private sealed class TestServerInstance : IUnityCliLoopServerInstance
 
             public string Endpoint => "test";
 
-            public void StartServer(bool clearServerStartingLockWhenReady = true)
+            public void StartServer()
             {
                 IsRunning = true;
             }

Assets/Tests/Editor/GetLogsUseCaseTests.cs

@@ -14,7 +14,6 @@ namespace io.github.hatayama.UnityCliLoop.Tests.Editor
     /// <summary>
     /// Unit tests for GetLogsUseCase
     /// Related classes: GetLogsUseCase, LogRetrievalService, LogFilteringService
-    /// Design reference: @Packages/docs/ARCHITECTURE_Unity.md - UseCase + Tool Pattern (DDD Integration)
     /// Test philosophy: Following Kent Beck's TDD and t-wada's testing principles
     /// </summary>
     [TestFixture]

Assets/Tests/Editor/ServerLifecycleContractTests.cs

@@ -9,30 +9,6 @@ namespace io.github.hatayama.UnityCliLoop.Tests.Editor
     /// </summary>
     public class ServerLifecycleContractTests
     {
-        [Test]
-        // Verifies that the default startup request releases the startup lock after readiness.
-        public void ReleaseStartupLockWhenReady_ClearsStartupLock_WhenServerReportsReady()
-        {
-            ServerInitializationRequest request =
-                ServerInitializationRequest.ReleaseStartupLockWhenReady();
-
-            Assert.That(request.StartupLockReleasePolicy, Is.EqualTo(ServerStartupLockReleasePolicy.ReleaseWhenReady));
-            Assert.That(request.ClearStartupLockWhenReady, Is.True);
-        }
-
-        [Test]
-        // Verifies that explicit-release startup requests preserve the startup lock for another owner.
-        public void PreserveStartupLockUntilExplicitRelease_KeepsStartupLock_ForExplicitRelease()
-        {
-            ServerInitializationRequest request =
-                ServerInitializationRequest.PreserveStartupLockUntilExplicitRelease();
-
-            Assert.That(
-                request.StartupLockReleasePolicy,
-                Is.EqualTo(ServerStartupLockReleasePolicy.PreserveUntilExplicitRelease));
-            Assert.That(request.ClearStartupLockWhenReady, Is.False);
-        }
-
         [Test]
         // Verifies that a successful initialization result carries the application-owned server handle.
         public void RunningInitializationResult_CarriesServerInstanceAndSuccess()

Assets/Tests/Editor/UnityCliLoopEditorSettingsRecoveryTests.cs

@@ -327,7 +327,7 @@ private sealed class TestServerInstance : IUnityCliLoopServerInstance
 
             public string Endpoint => "test";
 
-            public void StartServer(bool clearServerStartingLockWhenReady = true)
+            public void StartServer()
             {
             }
 

Assets/Tests/Editor/UnityCliLoopServerControllerStartupLockTests.cs

@@ -10,32 +10,10 @@
 namespace io.github.hatayama.UnityCliLoop.Tests.Editor
 {
     /// <summary>
-    /// Test fixture that verifies Unity CLI Loop Server Controller Startup Lock behavior.
+    /// Test fixture that verifies Unity CLI Loop Server Controller recovery behavior.
     /// </summary>
-    public class UnityCliLoopServerControllerStartupLockTests
+    public class UnityCliLoopServerControllerRecoveryTests
     {
-        [Test]
-        public void CreateOptionalServerStartingLock_WhenLockCreationSucceeds_ShouldReturnOwnershipToken()
-        {
-            // Tests that optional startup locks return the ownership token when creation succeeds.
-            UnityCliLoopServerControllerService service = CreateControllerService();
-
-            string token = service.CreateOptionalServerStartingLock(() => "token-123");
-
-            Assert.That(token, Is.EqualTo("token-123"));
-        }
-
-        [Test]
-        public void CreateOptionalServerStartingLock_WhenLockCreationFails_ShouldContinueWithoutThrowing()
-        {
-            // Tests that optional startup locks do not fail server startup when creation fails.
-            UnityCliLoopServerControllerService service = CreateControllerService();
-
-            string token = service.CreateOptionalServerStartingLock(() => null);
-
-            Assert.That(token, Is.Null);
-        }
-
         [Test]
         public void ScheduleStartupRecovery_WhenCalled_ExposesRecoveryTaskBeforeDeferredActionRuns()
         {
@@ -106,40 +84,6 @@ public async Task ScheduleStartupRecovery_WhenRecoveryIsAsync_KeepsTaskIncomplet
             Assert.That(service.RecoveryTask, Is.Null);
         }
 
-        [Test]
-        public async Task StartRecoveryIfNeededAsync_WhenStartupLockExists_ShouldReleaseLockAfterWarmup()
-        {
-            // Tests that recovery keeps the startup lock until post-bind warmup has completed.
-            TestServerInstanceFactory serverInstanceFactory = new();
-            UnityCliLoopServerLifecycleRegistryService lifecycleRegistry =
-                new UnityCliLoopServerLifecycleRegistryService();
-            UnityCliLoopEditorSettingsService editorSettingsService =
-                UnityCliLoopEditorSettingsTestFactory.CreateService();
-            ServerReadinessStateStore stateStore = CreateTestStateStore();
-            UnityCliLoopServerControllerService service = new(
-                serverInstanceFactory,
-                lifecycleRegistry,
-                new DomainReloadDetectionFileService(editorSettingsService, stateStore),
-                editorSettingsService,
-                stateStore,
-                new TestReadinessProbe());
-            string claimedLockPath = null;
-            ServerStartingLockService.OnOwnedLockFileClaimedForDeletionForTests = path => claimedLockPath = path;
-
-            try
-            {
-                await service.StartRecoveryIfNeededAsync(isAfterCompile: true, CancellationToken.None);
-
-                Assert.That(serverInstanceFactory.LastCreated.ClearServerStartingLockWhenReady, Is.False);
-                Assert.That(claimedLockPath, Is.Not.Null);
-            }
-            finally
-            {
-                ServerStartingLockService.OnOwnedLockFileClaimedForDeletionForTests = null;
-                ServerStartingLockService.DeleteLockFile();
-            }
-        }
-
         [Test]
         public async Task StartRecoveryIfNeededAsync_WhenReadinessSucceeds_ShouldPublishReadyState()
         {
@@ -270,13 +214,10 @@ private sealed class TestServerInstance : IUnityCliLoopServerInstance
         {
             public bool IsRunning { get; private set; }
 
-            public bool? ClearServerStartingLockWhenReady { get; private set; }
-
             public string Endpoint => "test";
 
-            public void StartServer(bool clearServerStartingLockWhenReady = true)
+            public void StartServer()
             {
-                ClearServerStartingLockWhenReady = clearServerStartingLockWhenReady;
                 IsRunning = true;
             }
 

Assets/Tests/Editor/UnityCliLoopServerStartupProtectionTests.cs

@@ -53,7 +53,6 @@ public void OnBeforeAssemblyReload_ShouldClearStartupProtectionBeforeRecovery()
             finally
             {
                 editorSettingsService.SaveSettings(originalSettings);
-                new DomainReloadDetectionFileService(editorSettingsService).DeleteLockFile();
                 service.ClearStartupProtection();
             }
         }
@@ -139,7 +138,7 @@ private sealed class TestServerInstance : IUnityCliLoopServerInstance
 
             public string Endpoint => "test";
 
-            public void StartServer(bool clearServerStartingLockWhenReady = true)
+            public void StartServer()
             {
             }