Skip to content

chore: Remove obsolete development files and stale architecture docs#1156

Merged
hatayama merged 1 commit into
mainfrom
chore/remove-obsolete-files
May 18, 2026
Merged

chore: Remove obsolete development files and stale architecture docs#1156
hatayama merged 1 commit into
mainfrom
chore/remove-obsolete-files

Conversation

@hatayama
Copy link
Copy Markdown
Owner

@hatayama hatayama commented May 18, 2026

Summary

  • Remove outdated editor-only development helpers and manual debug menus that are no longer part of the maintained package flow.
  • Remove stale architecture documents and references so the repository no longer points to outdated docs.
  • Keep remaining demo support editor-only so sample assemblies stay out of player builds.

User Impact

  • No runtime behavior change is expected for Unity package users.
  • Maintainers see less obsolete sample, debug, and documentation clutter when reviewing the project.

Changes

  • Deleted obsolete Assets/Editor development helpers, usage examples, and manual test menus.
  • Deleted outdated Unity and TypeScript architecture docs.
  • Removed stale design-reference comments that pointed to the deleted docs.
  • Removed unused test-only compiler worker accessors and their focused tests.
  • Marked the demo test-support assembly as Editor-only.
  • Rebuilt the TypeScript server bundle source map after source comment cleanup.

Verification

  • npm run lint
  • npm run build
  • uloop compile --project-path /Users/a12115/ghq/hatayama/unity-cli-loop --force-recompile false --wait-for-domain-reload true
  • git diff --check

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

📝 Walkthrough

Walkthrough

This PR removes architecture documentation files, editor debug and test utility windows, and design reference comments scattered throughout the codebase, plus test-only helper methods used by deleted test fixtures. The changes simplify the project structure by eliminating unmaintained documentation and test scaffolding.

Changes

Documentation and Test Utilities Removal

Layer / File(s) Summary
Editor test windows and debug menu utilities
Assets/Editor/CaptureTest/EditorWindowCaptureTest.cs, Assets/Editor/ConsoleMaskDebugger.cs, Assets/Editor/EditorDelayManualTests.cs, Assets/Editor/FindGameObjects/FindGameObjectsTestMenu.cs, Assets/Editor/CompileCheckWindow/CompileCheckerExample.cs, Assets/Editor/PathResolverTest.cs, Assets/Editor/LogGetter/LogGetterTestHelper.cs, Assets/Editor/LogGetter/LogGetterUsageExample.cs, Assets/Editor/VibeLoggerTest.cs, Assets/Editor/TestRunnerMenu.cs, Assets/Editor/ForCheck/Compile_Test.cs
Removes eleven editor window implementations and menu-driven test utilities that provided window capture testing, console flag debugging, delay manager testing, game object search testing, compile checking examples, path resolver testing, logging utilities, and test runner menu entries.
Architecture documentation files
Packages/docs/ARCHITECTURE_TypeScript.md, Packages/docs/ARCHITECTURE_TypeScript_ja.md, Packages/docs/ARCHITECTURE_Unity.md, Packages/docs/ARCHITECTURE_Unity_ja.md
Removes four architecture documentation files describing DDD/Clean Architecture patterns, layer organization, workflows, and design patterns for TypeScript server and Unity editor components, including Japanese translations.
Design reference comments from implementation files
Packages/src/Editor/Api/McpTools/*, Packages/src/Editor/Core/ApplicationServices/*, Packages/src/TypeScriptServer~/src/application/interfaces/*, Packages/src/TypeScriptServer~/src/domain/*, Assets/Tests/Editor/GetLogsUseCaseTests.cs
Removes inline "Design reference" comments that pointed to now-deleted architecture documentation from forty-six C# and TypeScript files across tools, use cases, application services, and domain models. No functional code or public APIs are changed.
Test helper methods and test fixtures
Packages/src/Editor/Compilation/SharedRoslynCompilerWorkerHost.cs, Assets/Tests/Editor/DynamicCodeToolTests/SharedRoslynCompilerWorkerHostTests.cs
Removes internal test-only helper methods exposing worker program generation, template paths, and marker tokens from SharedRoslynCompilerWorkerHost, plus deletes the entire NUnit test fixture that tested those helpers and covered compile request encoding and worker source edge cases.

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly and concisely summarizes the main objective: removing obsolete development files and stale architecture documentation. It matches the changeset which consists entirely of deletions of test utilities, examples, and documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/remove-obsolete-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 83 files

Re-trigger cubic

@hatayama hatayama force-pushed the chore/remove-obsolete-files branch from db203c2 to f0e7f0c Compare May 18, 2026 09:29
Prune stale manual development helpers and legacy architecture references,
and keep remaining demo support editor-only so sample assemblies do not
participate in player builds.
@hatayama hatayama force-pushed the chore/remove-obsolete-files branch from f0e7f0c to 142b26d Compare May 18, 2026 09:52
@hatayama hatayama merged commit d89ed21 into main May 18, 2026
8 checks passed
@hatayama hatayama deleted the chore/remove-obsolete-files branch May 18, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant