fix(ci): emit TypeScript declarations in tag npm publish workflow#10842
Merged
ArtyomSavchenko merged 1 commit intoMay 18, 2026
Merged
Conversation
|
Connected to Huly®: UBERF-16432 |
Signed-off-by: Igor Loskutov <igor.loskutoff@gmail.com>
dearlordylord
force-pushed
the
fix/tag-publish-npm-declarations
branch
from
May 16, 2026 15:52
99464c4 to
a885d18
Compare
ArtyomSavchenko
approved these changes
May 18, 2026
ArtyomSavchenko
merged commit May 18, 2026
18ef71b
into
hcengineering:develop
10 of 13 checks passed
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
Signed-off-by: Igor Loskutov <igor.loskutoff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10768.
#10768 fixed the manual npm publish workflow (
.github/workflows/publish-npm.yml) by runningrush validatebeforesafe-publish.js, but there is a second npm publication path in.github/workflows/main.yml: the tag-releasepublish-npmjob.That job still runs:
So tag releases can still publish packages after
rush buildonly.rush buildemitslib/; declarations are emitted byrush validate. This appears to be why0.7.423was published without declarations again.Evidence
Previous report and fix:
0.7.413packages advertisingtypes/index.d.tswhile omittingtypes/..github/workflows/publish-npm.yml.Current regression:
@hcengineering/core@0.7.423and@hcengineering/client@0.7.423npm metadata point at git heada00c01352d8ca78cf4a1367d57d136c7908d2dcb.The tag workflow run for
v0.7.423is:https://github.com/hcengineering/platform/actions/runs/25616518363
That publish path comes from
.github/workflows/main.yml, not the workflow fixed in #10768.Local before/after
On tag
v0.7.423, after clearing generated output for@hcengineering/core:lib/index.jspackedtypes/index.d.tspackedtypes/entriesrush build --to @hcengineering/corerush validate --to @hcengineering/coreafter buildSo adding
rush validatebefore publish fixes the packed artifact contents.Change
Add the same declaration-emission step to
.github/workflows/main.yml'spublish-npmjob that #10768 added to.github/workflows/publish-npm.yml.