Skip to content

update tiptap and hocuspocus to 3.x#10868

Open
aonnikov wants to merge 5 commits into
developfrom
chore-update-tiptap
Open

update tiptap and hocuspocus to 3.x#10868
aonnikov wants to merge 5 commits into
developfrom
chore-update-tiptap

Conversation

@aonnikov

@aonnikov aonnikov commented May 19, 2026

Copy link
Copy Markdown
Member

No description provided.

@aonnikov aonnikov marked this pull request as draft May 19, 2026 17:25
@huly-github-staging

huly-github-staging Bot commented May 19, 2026

Copy link
Copy Markdown

Connected to Huly®: UBERF-16458

github-advanced-security[bot]
github-advanced-security AI found potential problems May 19, 2026
View reviewed changes
Comment thread server/collaborator/src/server.ts Dismissed
@aonnikov
update tiptap and hocuspocus to 3.x
305795d 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov force-pushed the chore-update-tiptap branch from eb84eee to 305795d Compare May 20, 2026 03:55
@aonnikov
fix: attempt to fix tests
042a113 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov force-pushed the chore-update-tiptap branch 2 times, most recently from bfce54d to d77d659 Compare May 20, 2026 08:22
github-advanced-security[bot]
github-advanced-security AI found potential problems May 20, 2026
View reviewed changes
Comment thread foundations/core/packages/text-markdown/src/serializer.ts Dismissed
@aonnikov aonnikov force-pushed the chore-update-tiptap branch from d77d659 to 51ddb83 Compare May 20, 2026 09:13
@aonnikov
fix: get rid of @tiptap/html
cd1ab30 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov force-pushed the chore-update-tiptap branch 3 times, most recently from 40f9243 to 6e82645 Compare May 22, 2026 12:20
@aonnikov
attempt to fix ui tests
0430398 
Signed-off-by: Alexander Onnikov <Alexander.Onnikov@xored.com>
@aonnikov aonnikov force-pushed the chore-update-tiptap branch from 6e82645 to 0430398 Compare May 26, 2026 11:22
@aonnikov aonnikov marked this pull request as ready for review May 26, 2026 15:56
ArtyomSavchenko
ArtyomSavchenko reviewed Jun 18, 2026
View reviewed changes
Comment thread plugins/text-editor-resources/src/components/extension/hooks/isEmptyContent.ts
}
},
onCreate () {
this.parent?.()

@ArtyomSavchenko ArtyomSavchenko Jun 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[minor]Should we add an explanation as to why this is commented out now?

@ArtyomSavchenko

ArtyomSavchenko commented Jun 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

@aonnikov Could you also fix errors in rush validate phase?(CI / build (pull_request))

--[ FAILURE: @hcengineering/text-editor-resources (validate) ][ 16.58 seconds ]--


Error: /home/runner/work/platform/platform/plugins/text-editor-resources/src/components/extension/embed/embed.ts(121,38): error TS2345: Argument of type 'number | undefined' is not assignable to parameter of type 'number'.
  Type 'undefined' is not assignable to type 'number'.
Error: /home/runner/work/platform/platform/plugins/text-editor-resources/src/components/extension/imageExt.ts(169,31): error TS2345: Argument of type 'number | undefined' is not assignable to parameter of type 'number'.
  Type 'undefined' is not assignable to type 'number'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtyomSavchenko ArtyomSavchenko ArtyomSavchenko approved these changes

@BykhovDenis BykhovDenis Awaiting requested review from BykhovDenis

+1 more reviewer

@github-advanced-security github-advanced-security[bot] github-advanced-security[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aonnikov @ArtyomSavchenko @github-advanced-security