fix(notification): ignore blank browser push keys#10885
Merged
ArtyomSavchenko merged 1 commit intoMay 26, 2026
Merged
Conversation
Treat an unset front-service PUSH_PUBLIC_KEY as disabled browser push support instead of passing an empty string into PushManager.subscribe. Changes: - Add a small push public key accessor that normalizes undefined and blank metadata to undefined. - Use that accessor for both push availability checks and push subscription setup. - Preserve existing behavior when a real VAPID public key is configured. Behavioral effect: Instances without web push configured no longer attempt service worker push subscription with an invalid empty ECDSA key, while keeping browser push disabled until VAPID keys and the notification service are configured. Signed-off-by: Ignat Remizov <ignat@ignatremizov.com>
|
Connected to Huly®: UBERF-16475 |
ArtyomSavchenko
approved these changes
May 26, 2026
ArtyomSavchenko
merged commit May 26, 2026
a677899
into
hcengineering:develop
11 of 13 checks passed
MichaelUray
pushed a commit
to MichaelUray/huly-platform
that referenced
this pull request
Jul 9, 2026
Treat an unset front-service PUSH_PUBLIC_KEY as disabled browser push support instead of passing an empty string into PushManager.subscribe. Changes: - Add a small push public key accessor that normalizes undefined and blank metadata to undefined. - Use that accessor for both push availability checks and push subscription setup. - Preserve existing behavior when a real VAPID public key is configured. Behavioral effect: Instances without web push configured no longer attempt service worker push subscription with an invalid empty ECDSA key, while keeping browser push disabled until VAPID keys and the notification service are configured. Signed-off-by: Ignat Remizov <ignat@ignatremizov.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
git diff --checkgit diff --check upstream/develop..HEADnode common/scripts/install-run-rush.js build --to @hcengineering/notification-resourcesNotes